[Magiclysm] Concentrated Mana Serum don't give the Threshold Mutation

[Ker-Nes]

Describe the bug

No matter how many Concentrated Mana Serums, (the only magicylsm mutagen from what I can see), one takes, no matter if it's drunk or injected through the Item Action Menu (which as a sidenote, doesn't seem to be consuming the serum either), the Threshold mutation, Manatouched, doesn't appear.

Steps To Reproduce

Create a character. Debug spawn an arbitrarily large number of concentrated mana serums. Also spawn food and water so you don't kill yourself through hunger and thirst caused by the serum. Spawn syringe if you so desire. Consume and/or inject the Concentrated Mana Serums

Expected behavior

That at some point the Manatouched threshold mutation would be given to the character.

Screenshots

(At this point it was around 100 Concentrated Mana Serums taken in quick succession)

Versions and configuration

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: 5d36160 [64-bit]
• Graphics Version: Tiles
• Game Language: []
• Mods loaded: [ Bright Nights [dda], Magiclysm [magiclysm] ]

Additional context

No response

[leoCottret]

Looking at the magiclysm mutation file, in mods/magiclysm/traits/mutation.json, you can see that it's because you need to break the plant threshold to get the last mutation (Greater Mana Regeneration)

{
    "type": "mutation",
    "id": "MANA_REGEN3",
    "name": "Greater Mana Regeneration",
    "points": 8,
    "description": "Your natural mana regeneration is much faster than normal.",
    "prereqs": [ "MANA_REGEN2" ],
    "cancels": [ "BAD_MANA_REGEN1", "BAD_MANA_REGEN2", "BAD_MANA_REGEN3" ],
    "types": [ "MANA_REGEN" ],
    "threshreq": [ "THRESH_PLANT", "THRESH_MANA" ],
    "category": [ "PLANT", "MANATOUCHED" ],
    "flags": [ "NON_THRESH" ],
    "mana_regen_multiplier": 1.5
  }

That's (probably) intentional, but if you would like to get this mutation without becoming a plant mutant, you can remove the threshreq line completly.

You can't just remove the "THRESH_PLANT", part because there is a minimum limit of mutations type to break a threshold and there are not enough of mana type ones to break it.

[leoCottret]

Asking around, it seems Magiclysm is not that much maintained in CBN. I took a look at the current version of Magiclysm in DDA, and they removed the threeshold requierement here. I suggest we do the same to avoid those kind of report, and also because having a magic mutation blocked behind a plant threshold seems a bit strange, at least from a gameplay point of view. Waiting for feedbacks.