onthespot
onthespot copied to clipboard
[BUG] Build fails in macOS - problem with icon
Describe the bug Build fails in macOS, apparently due to a problem with the icon's format
To Reproduce Try to run build_mac.sh on a Mac
Expected behavior Build obtained in dist folder
Log```
3383 INFO: Building BUNDLE BUNDLE-00.toc Traceback (most recent call last): File "/Users/acyment/dev/onthespot/venv/lib/python3.11/site-packages/PyInstaller/building/icon.py", line 50, in normalize_icon_type from PIL import Image as PILImage ModuleNotFoundError: No module named 'PIL'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/acyment/dev/onthespot/venv/bin/pyinstaller", line 8, in
**System Information (please complete the following information):**
- OS: macOS 13.5
- OnTheSpot Version: 0.5 (downloaded sources on Aug 21th 2023)
**Additional context**
I converted the png file to icns, changed all 4 references to "png" to "icns" in build_mac.sh and build finished successfuly. Not sure if pull requests were accepted
Adding pip install --upgrade --force-reinstall Pillow
in build_mac.sh
seems to fix the issue:
...
echo " => Installing dependencies to venv with pip..."
pip install -r requirements.txt
pip install --upgrade --force-reinstall Pillow
...