solargraph icon indicating copy to clipboard operation
solargraph copied to clipboard

Solargraph formatting doesn't work if VScode format on save mode is modifications

Open mauricio-prl opened this issue 4 years ago • 1 comments

Hello everyone, I'm not used to report an issue, but I'm gonna try it.

I'm using VScode to write some ruby, and I'm loving using solargraph as linter formatter. But recently I found a little bug I guess: when Editor: Format On Save Mode is settled to modifications solargraph formatter seems not work.

image

some information:

Vscode version: March 2021 (version 1.55) ruby version: ruby 2.5.9 rails version: Rails 5.2.5 solargraph version: 0.40.4

If it's missing some important please tell me.

Examples:

with Editor: Format On Save Mode on file option

formatting

with Editor: Format On Save Mode on modifications option

not_working

Thanks you! :D

mauricio-prl avatar May 07 '21 18:05 mauricio-prl

Confirmed. I suspect this needs to be registered as a server capability, but Solargraph doesn't currently support it. I'll look into adding it.

castwide avatar May 29 '21 15:05 castwide