Breaking change for Sublime Text 3 in v0.39.0?

[3by7]

Environment: fresh Sublime Text 3 install (build 3211) on MacOS v10.15.5, using LSP and Solargraph v0.39.12.

The autocompletion seems lacking:

Comparing previous versions, v0.38.6 seemed to autocomplete as expected:

and some change in 0.39.0 could have triggered the current behaviour:

[castwide]

I don't have access to test on Sublime Text, so I added a "help wanted" tag to this one.

My first guess was that Sublime uses the stdio transport and garbage was getting introduced to the output stream, but I haven't been able to reproduce the problem using stdio in VS Code. That might be way off base, though; if that were the case, you'd probably get errors about malformed JSON-RPC messages.

[3by7]

Thank you @castwide. The screenshots include the logs generated by enabling these LSP settings:

	"log_debug": true,
	"log_payloads": true,
	"log_server": true,
	"log_stderr": true

Knowing nothing about the solargraph code and having no context about the changes added in 0.39.0, trying to debug it sounds a bit intimidating. What would be the best method calls to trace in order to scope down the problem?

[dputtick]

@3by7 Is this still a problem for you? I've tried to take a look at it with ST3 for MacOS. I can reproduce it with 0.39.13 and the latest version of the LSP plugin, but I had a lot of trouble getting older versions of LSP and solargraph working together locally. It seems to me that the not very good autocompletions are the fallback default Sublime Text completions. LSP has a setting "only_show_lsp_completions", did you have that turned on when you generated those screenshots? My guess is that this is a bug in the plugin and how it's interacting with native Sublime autocomplete, rather than a solargraph bug, but I don't have any evidence to back that up. As a sidenote, the plugin uses the socket transport, not stdio.

[3by7]

It is still a problem.

Here's a screenshot taken after uninstalling all solargraph versions except for solargraph-0.38.6 (so that's the only one running) and adding that setting (others are shown on the right side):