pygaggle icon indicating copy to clipboard operation
pygaggle copied to clipboard

Add duoBERT

Open ronakice opened this issue 4 years ago • 4 comments

I was looking into adding duo support (k-way ranking potentially) for MSMARCO and TREC-CAR.

For RelevanceExample, I was wondering if we can have documents as Union(List[Text], List[List[Text]]) instead of just List[Text]. I could also do something like this in the evaluate method in RerankerEvaluator. Another way is to add an is_duo argument to the various reranks/class.

Thoughts? @daemon @rodrigonogueira4

ronakice avatar Apr 29 '20 16:04 ronakice

Yeah, that sounds good to me! For now, I would worry only about duo and forget about the general case as we don't even know how to make it computationally viable

rodrigonogueira4 avatar Apr 29 '20 18:04 rodrigonogueira4

@wiltan-uw is on this!

ronakice avatar Nov 20 '20 09:11 ronakice

I'm wondering what the relationships between this issue and this repo is: https://github.com/castorini/duobert

Are we planning on deprecating the duobert repo, i.e., but into archive real-only mode?

lintool avatar Nov 22 '20 16:11 lintool

Yeah, I think archiving duobert repo is a good idea. It is in tensorflow, and it requires some manual steps to do reranking

rodrigonogueira4 avatar Nov 22 '20 16:11 rodrigonogueira4