castor icon indicating copy to clipboard operation
castor copied to clipboard

Published 20 hours ago • verified publisher icon castorini

conv_rnn refactoring

Open lintool opened this issue 6 years ago • 2 comments

Ref #99

conv_rnn and kim_cnn are both sentence classification models - they should share the same API, and in general be structured the same way.

@Impavidity @daemon please coordinate on this.

lintool avatar May 16 '18 19:05 lintool

#99 #101 Maybe we can have all the shared modules in /common/ and the model-specific stuff in the current directories. For example, the user runs something like python -m conv_rnn from the base directory.

daemon avatar May 23 '18 22:05 daemon

SST-1 torchtext Dataset is now available in the datasets module. SST-2 will be added in the next 2 weeks.

tuzhucheng avatar Jun 09 '18 21:06 tuzhucheng