castore icon indicating copy to clipboard operation
castore copied to clipboard

Add onEventPushed in EventStore constructor

Open joyanedel opened this issue 2 years ago â€ĸ 0 comments

Description đŸĻĢ

EventStore documentation indicates that the constructor is able to receive onEventPushed as an argument in the constructor but the base code doesn't support it

In the company I work, we are exploring castore in an eventsourcing based project and this fix can lead into cleaner code.

Fixes #178

Type of change 📝

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested? 🧑‍đŸ”Ŧ

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] core:package
  • [x] core:test
  • [x] message-bus-adapter-event-bridge:package
  • [x] message-bus-adapter-event-bridge:test
  • [x] event-storage-adapter-in-memory:test
  • [x] command-json-schema:package
  • [x] event-type-json-schema:package
  • [x] event-storage-adapter-redux:test
  • [x] event-storage-adapter-http:test
  • [x] message-queue-adapter-sqs:test
  • [x] event-storage-adapter-redux:package
  • [x] event-type-json-schema:test
  • [x] command-json-schema:test
  • [x] event-storage-adapter-in-memory:package
  • [x] event-type-zod:test
  • [x] command-zod:test
  • [x] demo-blueprint:package
  • [x] message-bus-adapter-event-bridge-s3:test
  • [x] demo-blueprint:test
  • [x] lib-react-visualizer:package
  • [x] lib-react-visualizer:test
  • [x] message-queue-adapter-in-memory:test
  • [x] event-storage-adapter-dynamodb:test
  • [x] message-bus-adapter-in-memory:test
  • [x] event-storage-adapter-dynamodb:package
  • [x] lib-test-tools:test
  • [x] lib-test-tools:package
  • [x] message-queue-adapter-in-memory:package
  • [x] demo-visualization:test
  • [x] demo-implementation:test
  • [x] docs:test
  • [x] lib-dam:test

Test Configuration: 🔧

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist: ✅

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

joyanedel avatar Jan 20 '24 01:01 joyanedel