Casper da Costa-Luis

Results 737 comments of Casper da Costa-Luis

- Pre-rebase branch: https://github.com/SyneRBI/SIRF/tree/torch-prerebase - Diff: https://github.com/SyneRBI/SIRF/compare/torch-prerebase...Imraj-Singh:SIRF:torch

Er... why would you pull in the deps requirements? The whole point of `pip install dep` is that `dep`'s own requirements automatically get installed. SIRF need only define its direct...

Or do you mean syncing/removing https://github.com/SyneRBI/SIRF-SuperBuild/blob/master/docker/requirements.txt in favour of https://github.com/SyneRBI/SIRF/blob/master/requirements.txt ?

Hmm yes, quite. The entire SuperBuild really could disappear if we could `pip install sirf`. The "correct" way would have `pip` automatically download all build dependencies (including `cmake`) and build...

For clarification, the gold standard would be: 1. leave it to the user to install + python (can be installed via conda) + g++/visual studio (g++ can be installed via...

`nipet=2.0.0` is py3-only. The NIPET libraries which STIR is linking against (https://github.com/UCL/STIR/blob/fe1af133aee5c44ce9fecd50993612f47d274b44/src/cmake/FindNiftyPET.cmake#L41-L45) are python modules so would've needed an appropriate version of python to build.

1. merge https://github.com/CCPPETMR/SIRF/pull/160 2. merge #109 3. rebase this and merge close #106?

EDIT new strategy: - [x] @paskino merge https://github.com/CCPPETMR/SIRF/pull/160 (no dependencies) - [x] @casperdcl rebase and merge https://github.com/CCPPETMR/SIRF/pull/163 (no dependencies) - [ ] @paskino @casperdcl rebase and merge this (#112, depends...

got Abofazl (postdoc) to try via conda in a vbox on windows ```bash conda create -n sirf python=3 conda activate sirf conda install -c conda-forge -c paskino sirf ``` -...

> I guess we'll end up creating several recipes which create the packages sirf depends on, and sirf. helps that STIR is now in `conda-forge`