Casper da Costa-Luis comments

Results 737 comments of


                                            Casper da Costa-Luis

dataexamples tidy

FYI `zenodo_get>=1.6.1` will be on `conda-forge` as soon as https://github.com/conda-forge/zenodo_get-feedstock/pull/10 is merged. It's already on PyPI (`pip`).

callbacks not a package and limited doc available

> ```py > import cil.optimisation.utilities.callbacks.Callback as Callback > ``` where did you see this @KrisThielemans? It should indeed be: ```py from cil.optimisation.utilities.callbacks import Callback ``` FYI the docs are at...

Change in behaviour of PDHG

For now you could use: ```python algo = PDGH(...) algo.max_iterations = 1000000 for i in iter(algo): ... # do something with algo ``` but it might stop working in a...

Change in behaviour of PDHG

> I've switched to doing the progress bar updates from a callback: [mantidproject/mantidimaging@5006fd3](https://github.com/mantidproject/mantidimaging/commit/5006fd30d5ae81a89c7904d32af9af71cb175585) lgtm! > It would be good if there was a mention in the release notes about the...

Refactor framework

@manchester-jhellier I just fixed the merge conflicts :)

Refactor framework

just one error left: ```py ====================================================================== FAIL: test_VectorGeometry_allocate_complex (test_DataContainer.TestDataContainer.test_VectorGeometry_allocate_complex) ---------------------------------------------------------------------- Traceback (most recent call last): File "CIL/Wrappers/Python/test/test_DataContainer.py", line 729, in test_VectorGeometry_allocate_complex self.assertNotEqual(numpy.sum(data.array).imag, 0) AssertionError: 0.0 == 0 ```

Refactor framework

According to https://github.com/manchester-jhellier/CIL/blob/daae9d2eda5a6d627e2cf08cf10ff2121b4c444a/Wrappers/Python/cil/framework/data_container.py#L1527-L1541 it seems `RANDOM` does both `real` & `imag`, while `RANDOM_INT` only does `real` (so `imag == 0`).