Casper da Costa-Luis
Casper da Costa-Luis
fixed by https://github.com/iterative/cml.dev/pull/324? Or was there some other reason you re-opened @0x2b3bfa0? If so please do re-open (again)
thanks @deepyaman! Yes feel free to have a go. [`--unshallow`](https://github.com/iterative/cml/blob/f34a0892691e64caa8a23db96276eb8b593153c0/bin/cml/repo/prepare.js#L16) can be soft-deprecated using [`.hidden`](https://github.com/iterative/cml/blob/341f32e0dcd7a5d2f9af5d504017ac3fa8fcea6e/bin/cml/asset/publish.js#L32) :)
no problem, looking forward to a PR @deepyaman :)
Ah don't worry about testing locally - a lot of functionality needs actual CI to test effectively. Don't worry if PR tests also fail, we can fix them :)
Yes I think this is a needed UX (error messaging) improvement.
- How do you install `Microsoft.winget.source_8wekyb3d8bbwe` after it's been removed? It's missing from my `winget list` (https://github.com/microsoft/winget-cli/issues/2666#issuecomment-1303448425) + reinstalling [the msixbundle](https://github.com/microsoft/winget-cli/releases) didn't fix the issue, nor did `winget source reset...
btw both utterances & giscus use GH issues to host comments so if we add a button "go to GH issue to comment" then we won't need "Sign in with...
> casperdcl 's idea of putting a link looks more feasible but could we show the discussions beneath the page? yes discussions are visible on-page without logging in/permissions. It's just...
> inside a `iframe` we are unable to edit its contents ah well it's all opensource so we could just fork & modify :)
I feel it's `p2-nice-to-have`