Casper da Costa-Luis
Casper da Costa-Luis
Not sure if related, but also if token lacks permission: ```hcl {"level":"error","message":"Forbidden","stack":"Error: Forbidden at Gitlab.request (/usr/lib/node_modules/@dvcorg/cml/src/drivers/gitlab.js:418:38) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async Gitlab.commentCreate (/usr/lib/node_modules/@dvcorg/cml/src/drivers/gitlab.js:74:5) at async CML.commentCreate (/usr/lib/node_modules/@dvcorg/cml/src/cml.js:183:12) at async Object.exports.handler...
@dacbd did you mean to close this?
looks like this issue is a distinct action point under #1058. Would keep it open until addressed. Specifically: - better message for `Resource not accessible by integration` - better message...
`s/attachment/attach/`
I wasn't following noun convention. Now that I think of it, I was assuming verb for simple commands and noun for complex ones... So they're all (possibly abbreviated) verbs apart...
> I don't think verbs are appropriate strictly it's about being an imperative/action: `X now!` so the only outliers are: - `runner` -> `runner {launch,create}` - `tensorboard-dev` -> `tensorboard {dev,push,link,connect,publish...}`...
1. Updated description to be `cml noun... [--mutex-action-verb]`. With aliases, this retains backwards-compatibility 2. I'd also say default-verbs don't need be implemented (e.g. `cml pr` without flags obviously implies *create*,...
TL;DR for now we should do: - `send-comment` -> `{comment,report} [{--create,--update}]` - `rerun-workflow` -> `workflow [--rerun]` but keep backward-compatibility
Hmm. `cml report [create]` won't work. `create` will have to be `` (not `[optional]`) due to the next arg also being a ``: `cml comment {create,update} `. Isn't `cml comment...
Surely `cml pr [create]` -> `cml pr create`?