tree-sitter-module icon indicating copy to clipboard operation
tree-sitter-module copied to clipboard

sql not building

Open wkirschbaum opened this issue 2 years ago • 8 comments

Building sql
./build.sh: line 95: cd: sql/src: No such file or directory

wkirschbaum avatar Mar 12 '23 19:03 wkirschbaum

they switch the generated files to the gh-pages branch

rosbo018 avatar Mar 13 '23 02:03 rosbo018

What? That's strange, why?

casouri avatar Mar 13 '23 02:03 casouri

so they can put it on their github pages page I guess https://github.com/DerekStride/tree-sitter-sql/commit/b2f6b30ce12cbddfb663473457b670f2b3bffaa9 https://derek.stride.host/tree-sitter-sql/

rosbo018 avatar Mar 13 '23 11:03 rosbo018

#26

rosbo018 avatar Mar 13 '23 12:03 rosbo018

Is it perhaps not better to ask them not to do it, or at leave the file on the main branch as well?

wkirschbaum avatar Mar 13 '23 17:03 wkirschbaum

I wouldn't bother, we can just modify our script to accommodate the branch, which rosbo018 has done, thanks!

casouri avatar Mar 18 '23 08:03 casouri

FYI, I've collected some info regarding the issue of whether to have generated source in a grammar repository here.

Although it's taking a long time, I believe there were folks who thought it wasn't so great to keep the generated parser source as part of one's repository and that at some point, at least the tree-sitter organization repositories were going to be moving away from doing so.

sogaiu avatar Apr 13 '23 14:04 sogaiu

Thank you for the research! Well, as long as there's a standard and (relatively) secure way to get the parser.c files, I'm ok with it. If you can, please keep us updated with the progress of events, thanks!

casouri avatar Apr 13 '23 21:04 casouri