nutshell icon indicating copy to clipboard operation
nutshell copied to clipboard

Remove Wallet V0 Support

Open KvngMikey opened this issue 2 months ago • 2 comments

Fixes #720

Summary

This PR removes the deprecated v0 wallet API and its helper (wallet_deprecated.py), along with all related references in v1_api.py and other wallet modules.

  • All pytest suites (wallet + full repo) pass successfully.
  • Only intentional legacy compatibility remains (like PostMeltResponse_deprecated in v1_api.py for older mints).

KvngMikey avatar Oct 29 '25 22:10 KvngMikey

love to see it image

callebtc avatar Nov 04 '25 14:11 callebtc

love to see it image

lol, that's why i'm here.

KvngMikey avatar Nov 04 '25 15:11 KvngMikey

Codecov Report

:x: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 64.25%. Comparing base (4a4b7f7) to head (ad39580). :warning: Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
cashu/wallet/v1_api.py 88.88% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #814       +/-   ##
===========================================
+ Coverage   47.84%   64.25%   +16.41%     
===========================================
  Files          90       90               
  Lines       10592    10643       +51     
===========================================
+ Hits         5068     6839     +1771     
+ Misses       5524     3804     -1720     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 30 '25 18:11 codecov[bot]