sqldelight
sqldelight copied to clipboard
cashapp
Hardcoded database implementation package name
Personally I want to get rid of this file at all and move the implementation just below the Database interface with private accessor and also remove the KClass hack.
Personally I want to get rid of this file at all and move the implementation just below the Database interface with private accessor and also remove the
KClasshack.
I think splitting the file helps with debugging. When you encounter a problem during use, the entire file is not generated, which may make it more difficult to locate the problem code. For this PR, I am just not satisfied with the generated naming only.
I think splitting the file helps with debugging. When you encounter a problem during use, the entire file is not generated, which may make it more difficult to locate the problem code.
I don't understand this specific use-case: You do have problems with code gen, and you need debug the generating of the database file. If so, this is a bug in sqldelight but this should not be "improved" by changing the generated file name.
Do you want to change the PR? Otherwise, I can take it.
I think splitting the file helps with debugging. When you encounter a problem during use, the entire file is not generated, which may make it more difficult to locate the problem code.
I don't understand this specific use-case: You do have problems with code gen, and you need debug the generating of the database file. If so, this is a bug in sqldelight but this should not be "improved" by changing the generated file name.
Do you want to change the PR? Otherwise, I can take it.
I don't like the generated naming of the package name. It makes me feel this is ugly. This is my only motivation for submitting this PR. You should create a new PR if you have other ideas for this project.
Also, the reason I changed the test file is because it's associative.