sqldelight icon indicating copy to clipboard operation
sqldelight copied to clipboard

Update plugin intellij to v1.9.0

Open renovate[bot] opened this issue 2 years ago • 12 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jetbrains.intellij 1.6.0 -> 1.9.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Jul 08 '22 14:07 renovate[bot]

sql-psi uses 1.9.0 too but Android Studio 213.6777.52 (Dolphin (2021.3.1) Canary): https://github.com/AlecStrong/sql-psi/blob/7c3d442cb7033fd1d088ec06730be598c68c7603/gradle/libs.versions.toml#L3

sqldelight uses Android Studio 211.7628.21 (Bumblebee (2021.1.1) Patch 3). Do we want to use the same version?

But bumping Android Studio to 213.6777.52 (sql-psi) or to the latest release 212.5712.43 (Chipmunk (2021.2.1) Patch 2) didn't work too. I still get this error:

java.lang.RuntimeException: Could not find installation home path. Please make sure bin/idea.properties is present in the installation directory.

hfhbd avatar Sep 08 '22 08:09 hfhbd

yea I've gone back and forth on this, I used to think of it as the IJ Plugin's compileSdk, so the lowest supported version, but we have the task which checks against all supported versions on CI so I think we could reasonably bump it to whatever latest version we want

AlecKazakova avatar Sep 08 '22 12:09 AlecKazakova

That exception is bizarre though, it might just be worth filing on the intellij gradle plugin repo to see if it has an obvious solution

AlecKazakova avatar Sep 08 '22 12:09 AlecKazakova

Yeah, I think creating an issue is the best idea :D

Honestly, I don't know the effect bumping the version, I just want to test the latest version, which failed too...

hfhbd avatar Sep 08 '22 12:09 hfhbd

That exception is bizarre though, it might just be worth filing on the intellij gradle plugin repo to see if it has an obvious solution

is it related to this https://plugins.jetbrains.com/docs/intellij/testing-faq.html#how-to-test-a-jvm-language

aperfilyev avatar Sep 08 '22 12:09 aperfilyev

@aperfilyev But how do you get these sources?

hfhbd avatar Sep 08 '22 13:09 hfhbd

@aperfilyev But how do you get these sources?

you just clone them from https://github.com/JetBrains/intellij-community

aperfilyev avatar Sep 08 '22 13:09 aperfilyev

@aperfilyev Hm, I dislike cloning these files, although they didn't change a lot. But I will try it.

hfhbd avatar Sep 08 '22 13:09 hfhbd

@aperfilyev Hm, I dislike cloning these files, although they didn't change a lot. But I will try it.

I've just tried and tests fail with a different error

    com.intellij.testFramework.TestLogger$TestLoggerAssertionError: Indexing of light_temp_2EUHnOiv7jGmAVb78VU9iRom761 has failed
        at app//com.intellij.testFramework.TestLogger.error(TestLogger.java:45)
        at app//com.intellij.openapi.diagnostic.Logger.error(Logger.java:208)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl.runActivity(StartupManagerImpl.kt:253)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl.access$runActivity(StartupManagerImpl.kt:59)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl$executeActivitiesFromExtensionPoint$1.accept(StartupManagerImpl.kt:193)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl$executeActivitiesFromExtensionPoint$1.accept(StartupManagerImpl.kt:59)
        at app//com.intellij.openapi.extensions.impl.ExtensionPointImpl.processImplementations(ExtensionPointImpl.java:310)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl.executeActivitiesFromExtensionPoint(StartupManagerImpl.kt:178)
        at app//com.intellij.ide.startup.impl.StartupManagerImpl.projectOpened(StartupManagerImpl.kt:153)
        at app//com.intellij.openapi.project.impl.ProjectManagerExImplKt.openProject(ProjectManagerExImpl.kt:491)
        at app//com.intellij.openapi.project.impl.ProjectManagerExImplKt.access$openProject(ProjectManagerExImpl.kt:1)
        at app//com.intellij.openapi.project.impl.ProjectManagerExImpl.openProject(ProjectManagerExImpl.kt:260)
        at app//com.intellij.project.TestProjectManager.openProject(TestProjectManager.kt:90)
        at app//com.intellij.testFramework.PlatformTestUtil.openProject(PlatformTestUtil.java:1233)
        at app//com.intellij.testFramework.LightPlatformTestCase.doSetup(LightPlatformTestCase.java:278)
        at app//com.intellij.testFramework.fixtures.impl.LightIdeaTestFixtureImpl.setUp(LightIdeaTestFixtureImpl.java:40)
        at app//com.intellij.testFramework.fixtures.impl.CodeInsightTestFixtureImpl.lambda$setUp$28(CodeInsightTestFixtureImpl.java:1242)
        at app//com.intellij.testFramework.EdtTestUtil.runInEdtAndWait(EdtTestUtil.java:33)
        at app//com.intellij.testFramework.fixtures.impl.CodeInsightTestFixtureImpl.setUp(CodeInsightTestFixtureImpl.java:1241)
        at app//com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase.setUp(LightJavaCodeInsightFixtureTestCase.java:105)
        at app//app.cash.sqldelight.intellij.SqlDelightFixtureTestCase.setUp(SqlDelightFixtureTestCase.kt:39)
        at app//com.intellij.testFramework.UsefulTestCase.invokeSetUp(UsefulTestCase.java:482)
        at app//com.intellij.testFramework.UsefulTestCase.defaultRunBare(UsefulTestCase.java:474)
        at app//com.intellij.testFramework.UsefulTestCase.lambda$runBare$12(UsefulTestCase.java:527)
        at app//com.intellij.testFramework.EdtTestUtil.lambda$runInEdtAndWait$1(EdtTestUtil.java:40)
        at app//com.intellij.openapi.application.TransactionGuardImpl.runWithWritingAllowed(TransactionGuardImpl.java:214)
        at app//com.intellij.openapi.application.TransactionGuardImpl.access$200(TransactionGuardImpl.java:21)
        at app//com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:196)
        at app//com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:794)
        at app//com.intellij.openapi.application.impl.ApplicationImpl.lambda$invokeAndWait$7(ApplicationImpl.java:451)
        at app//com.intellij.openapi.application.impl.LaterInvocator$1.run(LaterInvocator.java:134)
        at app//com.intellij.openapi.application.impl.FlushQueue.doRun(FlushQueue.java:84)
        at app//com.intellij.openapi.application.impl.FlushQueue.runNextEvent(FlushQueue.java:133)
        at app//com.intellij.openapi.application.impl.FlushQueue.flushNow(FlushQueue.java:46)
        at app//com.intellij.openapi.application.impl.FlushQueue$FlushNow.run(FlushQueue.java:189)
        at [email protected]/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
        at [email protected]/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
        at [email protected]/java.awt.EventQueue$4.run(EventQueue.java:721)
        at [email protected]/java.awt.EventQueue$4.run(EventQueue.java:715)
        at [email protected]/java.security.AccessController.doPrivileged(Native Method)
        at [email protected]/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
        at [email protected]/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
        at app//com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:885)
        at app//com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:754)
        at app//com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$6(IdeEventQueue.java:441)
        at app//com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:825)
        at app//com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$7(IdeEventQueue.java:440)
        at app//com.intellij.openapi.application.impl.ApplicationImpl.runIntendedWriteActionOnCurrentThread(ApplicationImpl.java:794)
        at app//com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:486)
        at [email protected]/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
        at [email protected]/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
        at [email protected]/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
        at [email protected]/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
        at [email protected]/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
        at [email protected]/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

aperfilyev avatar Sep 08 '22 13:09 aperfilyev

"Nice"? :D Wanna push it though?

hfhbd avatar Sep 08 '22 13:09 hfhbd

I've asked about it in the intellij slack, waiting for a follow up tomorrow

aperfilyev avatar Sep 08 '22 15:09 aperfilyev

Screenshot 2022-09-09 at 17 54 23 This is the answer I got from Intellij folks Linked issue: https://github.com/JetBrains/gradle-intellij-plugin/issues/656 Actual changes: https://github.com/JetBrains/gradle-intellij-plugin/commit/fafb4f29fd91adacc96bda9ed4891dc160763d3d#diff-5e3ac4ace346e77ba79cb273e7d04d8827d7fd3dfec9bbcd17553992aecc3444R34

aperfilyev avatar Sep 09 '22 14:09 aperfilyev

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

renovate[bot] avatar Nov 28 '22 11:11 renovate[bot]

I finally fixed the java.lang.RuntimeException: Could not find installation home path. Please make sure bin/idea.properties is present in the installation directory. error message, but this required some additional upgrades, grammarkit-composer + sql-psi. Now I will try to merge the #3454 into my local branch, so maybe we can finally update this plugin and the intellij version.

hfhbd avatar Dec 01 '22 12:12 hfhbd

Fixed in #3755

hfhbd avatar Jan 03 '23 10:01 hfhbd