paparazzi icon indicating copy to clipboard operation
paparazzi copied to clipboard

Configure native platform transformed path directly in test task

Open jrodbx opened this issue 2 years ago • 1 comments

Based on offline discussion with and suggestion by @liutikas.

Adding the native platform transformed unzipped directory to the resources.txt generated by PrepareResourcesTask was a design mistake and prevents that task from being truly cacheable, since it has an absolute file path to the user home directory and is also platform OS dependent. Instead, we wire that directly as an input to the Test task.

According to @liutikas, this also brings some performance improvement as the transform/unzip process was being performed during configuration time.

Closes https://github.com/cashapp/paparazzi/issues/495 and https://github.com/cashapp/paparazzi/pull/499.

jrodbx avatar Aug 07 '22 06:08 jrodbx

I was about to PR this (https://github.com/liutikas/paparazzi/tree/platform-input) :)

liutikas avatar Aug 08 '22 03:08 liutikas

Anything else missing for this to land?

liutikas avatar Sep 01 '22 22:09 liutikas

Was busy prepping then attending Droidcon NYC!

Starting to catch up on the repo activity. Will aim to land this soon.

jrodbx avatar Sep 03 '22 19:09 jrodbx

Gonna try to land this today

jrodbx avatar Sep 06 '22 14:09 jrodbx