paparazzi icon indicating copy to clipboard operation
paparazzi copied to clipboard

Optional snapshot root directory gradle property

Open brenpearson opened this issue 3 years ago • 5 comments

Allows the consumer of the Paparazzi library to specify where they want the snapshots to be saved. This includes creating a gradle plugin extension for Paparazzi with this property in it, we can add other configurable properties to this extension in future.

This can be set as shown in the consumer's gradle file

paparazzi {
    snapshotRootDirectory = file("where/I/want/the/snapshots")
}

brenpearson avatar Jul 28 '22 11:07 brenpearson

Is there any blocker for this PR?

JavierSegoviaCordoba avatar Feb 28 '23 12:02 JavierSegoviaCordoba

@brenpearson do you still have interest in this?

I can fork your implementation if you lack of time to continue working on this.

JavierSegoviaCordoba avatar Mar 14 '23 12:03 JavierSegoviaCordoba

@JavierSegoviaCordoba I'm not going to be able to update this within the next couple of weeks. If you have time then by all means, otherwise I'll come back and take a look in probably 2 weeks time 🙏

brenpearson avatar Mar 15 '23 11:03 brenpearson

Can I push on this branch or should I create a new PR? @brenpearson commits are preserved in both cases.

EDIT: As there are conflicts, I am going to create a different PR and I will share the link here.

JavierSegoviaCordoba avatar Mar 15 '23 14:03 JavierSegoviaCordoba

Updated PR with @TWiStErRob suggestion: https://github.com/cashapp/paparazzi/pull/736

JavierSegoviaCordoba avatar Mar 15 '23 14:03 JavierSegoviaCordoba

Exporting this as a repo-level (vs module-level) config is likely the approach we'll want here; when would modules otherwise have different settings?

jrodbx avatar Nov 07 '24 09:11 jrodbx