paparazzi icon indicating copy to clipboard operation
paparazzi copied to clipboard

verifyPaparazziRelease --rerun-tasks always successful

Open mshearer123 opened this issue 2 years ago • 6 comments

Description Running ./gradlew verifyPaparazziRelease --rerun-tasks always passes. Except the images change and the report shows the difference.

Expected behavior verifyPaparazziRelease after changing a composable should fail.

Additional information:

  • Paparazzi Version: 1.0.0
  • OS: MacOS Monterey (M1 Pro)
  • Compile SDK: 31
  • Gradle Version: 7.4.2
  • Android Gradle Plugin Version: 7.1.1

Screenshots paparazzi.zip

mshearer123 avatar Jun 14 '22 17:06 mshearer123

I'm experiencing the same thing, and have done some more research on #453.

Dambakk avatar Jun 14 '22 18:06 Dambakk

I'm not sure it's the same @Dambakk , I think the tasks run, but I would expect the verify task to fail.

mshearer123 avatar Jun 14 '22 18:06 mshearer123

Ah, I guess you're right. Anyway, I think I experience your issue: https://github.com/cashapp/paparazzi/issues/453#issuecomment-1155523277

Dambakk avatar Jun 14 '22 19:06 Dambakk

@mshearer123 I'm facing the same issue testing with a simple Compose screen. Have you found any solution?

@Dambakk your scenario didn't help, unfortunately.

novachevskyi avatar Jun 22 '22 13:06 novachevskyi

@novachevskyi nope, no luck yet

mshearer123 avatar Jun 23 '22 10:06 mshearer123

@mshearer123 I wonder if the difference was below the 0.1% threshold. In those cases, it is possible to get a verify to pass (because it's small enough of a difference) but still get a new image on a composable change.

Can you provide a sample/repro? Without that, it's hard for me to dig deeper.

jrodbx avatar Sep 21 '22 17:09 jrodbx

Closing due to inactivity, please re-open if the issue re-appears.

jrodbx avatar Dec 07 '22 20:12 jrodbx