paparazzi icon indicating copy to clipboard operation
paparazzi copied to clipboard

AGP 9 incompatibility because of BaseExtension usage

Open gabrielittner opened this issue 7 months ago • 6 comments

Description

Paparazzi's Gradle plugin accesses AGP's BaseExtension (here). In AGP 9 this type isn't available anymore unless you set android.newDsl=false.

Reference: https://developer.android.com/build/releases/agp-preview#android-gradle-plugin-new-dsl

Steps to Reproduce

Use Paparazzi with AGP 9.

Additional information:

  • Paparazzi Version: 2.0.0-alpha02
  • OS: macOS
  • Compile SDK: 36
  • Gradle Version: 9.0.0
  • Android Gradle Plugin Version: 9.0.0-alpha04

gabrielittner avatar Sep 09 '25 07:09 gabrielittner

Fix is here: https://github.com/cashapp/paparazzi/pull/2106/files#diff-197fe329c4084290675667dd6b6194a6db2af00d5410525ad2d64bf4591d9b82L150-L159

@geoff-powell looking at the changes around there some of that could be merge-able to master to support both AGP 8.x and 9.x at the same time?

TWiStErRob avatar Sep 22 '25 18:09 TWiStErRob

Yep, had the same thoughts as well when fighting with AGP 9. Might have a separate PR with the variant namespace change to simplify things

geoff-powell avatar Sep 22 '25 18:09 geoff-powell

jvmTarget changes might be also viable on its own.

TWiStErRob avatar Sep 22 '25 18:09 TWiStErRob

Fix is here: https://github.com/cashapp/paparazzi/pull/2106/files#diff-197fe329c4084290675667dd6b6194a6db2af00d5410525ad2d64bf4591d9b82L150-L159

@geoff-powell looking at the changes around there some of that could be merge-able to master to support both AGP 8.x and 9.x at the same time?

Fixed this in separate pr: https://github.com/cashapp/paparazzi/pull/2114/files

geoff-powell avatar Sep 23 '25 19:09 geoff-powell

Could we please release a fixed version of the plugin?

liutikas avatar Nov 13 '25 05:11 liutikas

It would be great to have a new alpha with the base extension change and this PR for the new KMP plugin https://github.com/cashapp/paparazzi/pull/2115

gabrielittner avatar Nov 13 '25 07:11 gabrielittner