misk icon indicating copy to clipboard operation
misk copied to clipboard

WIP: Simplify misk-redis implementation

Open keeferrourke opened this issue 11 months ago • 4 comments

...by deferring to RealPipelinedRedis.

Follow up for https://github.com/cashapp/misk/pull/3195.

This change deduplicates a lot of logic between RealRedis and RealPipelinedRedis, by always pipelining commands.

This incurs a little overhead since we have to create, sync, and close a pipeline every time (even for just one command), but significantly simplifies the client. I also removed the old timing proxy, so hopefully that compensates for the added overhead of the pipelines.


I recommend reviewing this change commit-by-commit.

keeferrourke avatar Mar 21 '24 23:03 keeferrourke