hermit icon indicating copy to clipboard operation
hermit copied to clipboard

sources git URL not supporting tags

Open rolandknight opened this issue 3 years ago • 6 comments

The bin/hermit.hcl sources variable is not supporting repo tags. Example: sources = ["https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"]

Results in this error: fatal:hermit: /home/rolandknight/git/gitlab.com/onis-oss/tlc/sandbox/bin/hermit.hcl: unsupported source "https://gitlab.com/onis-oss/hermit-packages.git#onis-oss"

rolandknight avatar Jun 07 '22 13:06 rolandknight

Great point, we should definitely support that!

alecthomas avatar Jun 08 '22 00:06 alecthomas

I can help with that. Can you point me to what needs to be changed?

On Jun 7, 2022, at 8:23 PM, Alec Thomas @.***> wrote:

 Great point, we should definitely support that!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

rolandknight avatar Jun 08 '22 00:06 rolandknight

Oh nice, thank you. The code is currently living here, for downloading a package via git. I think this logic could be pulled out into a top-level git package, and reused by the package caching, and the sources.

alecthomas avatar Jun 08 '22 01:06 alecthomas

Happy to jump into this and assist. We're wanting to use atlas and unfortunately their latest release is git tag only – not github release.

jufemaiz avatar Mar 02 '23 23:03 jufemaiz

I'm not sure what atlas is, but this issue is specifically talking about using git tags for extra package manifest sources, not for packages themselves.

If this is Atlas, you'd likely download the tarballs from their site. If you're talking about using tags for auto-versioning, a better option would be to use the html auto-versioning. This is also what we do for Go.

alecthomas avatar Mar 02 '23 23:03 alecthomas

@alecthomas thanks for the clarification! Taking up the need for an index page of releases with the Atlas team (it's this atlas for clarification).

jufemaiz avatar Mar 02 '23 23:03 jufemaiz