hermit-packages
hermit-packages copied to clipboard
`protoc-gen-connect-go` has moved
see https://github.com/connectrpc/connect-go/releases/tag/v1.11.0
One path to support would be just to update the org
- build: https://github.com/cashapp/hermit-build/blob/ffb06bd1f5f6e675d9afcc44823bc0702636db0f/go-tools/Makefile#L13
- package: https://github.com/cashapp/hermit-packages/blob/master/protoc-gen-connect-go.hcl
However, the code doesn't appear to be backwards incompatible
cannot use greeter (variable of type *GreetServer) as ballonv1connect.BalloonServiceHandler value in argument to ballonv1connect.NewBalloonServiceHandler: *GreetServer does not implement ballonv1connect.BalloonServiceHandler (wrong type for method Greet)
have Greet(context.Context, *"connectrpc.com/connect".Request[ballonv1.GreetRequest]) (*"connectrpc.com/connect".Response[ballonv1.GreetResponse], error)
want Greet(context.Context, *"github.com/bufbuild/connect-go".Request[ballonv1.GreetRequest]) (*"github.com/bufbuild/connect-go".Response[ballonv1.GreetResponse], error)compiler[InvalidIfaceAssign](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#InvalidIfaceAssign)
which is super fun to fix...
I don't think this should effect any current tooling or libraries right? The old code is still present AFAICT, and we build our own binaries for this.
it won't affect any current tooling - but it will keep those tools pinned on an older version of connect. the issue lies with supporting new versions of connect