selectr icon indicating copy to clipboard operation
selectr copied to clipboard

Fix deselectOption on deselecting the first list entry, if only first entry is selected

Open Parama91 opened this issue 8 years ago • 3 comments

An error occured on deselecting the last selected option, if first in list of options. After adding the missing ' in the function deselectOption to the command, deselection is working and footer is updating fine again. New command: e("option[value='"+e(t).data("val")+"']",this.source).prop("selected",!1)

Parama91 avatar Oct 11 '17 12:10 Parama91

Make the changes in the src directory and re-run the build w/ npm run build. I didn't really know anything about node when I wrote this, so you'll need coffeescript installed globally.

I sincerely apologize for the coffeescript; I used to think it was a good idea — it's not. When I get some free time, I'd like to rewrite this in TypeScript.

caseyWebb avatar Oct 11 '17 15:10 caseyWebb

I see your fancy-shmancy first-time contributor badge up there — welcome! If you need/want any help, reach out to me on https://gitter.im/caseyWebb.

caseyWebb avatar Oct 11 '17 15:10 caseyWebb

Thanks for the information! First pull request, first mistake 😄 . Will try to install coffeescript and re-run the build in the next few days, if i get enough time.

Parama91 avatar Oct 12 '17 06:10 Parama91