just icon indicating copy to clipboard operation
just copied to clipboard

Allow listing of groups (also recursively)

Open Spatenheinz opened this issue 1 year ago • 4 comments

This commit is in reference to: https://github.com/casey/just/issues/2195

It took me some time to implement this feature, with getting to understand the layout, trying to parameterize it to remove code duplication and going on vacation.

With this commit it should be possible to list all occurences of a group. If a submodule and a group has the same name the submodule takes precedence.

It was a nightmare to rebase this. I hope it is working as intended still (at least the tests should pass :D)

Let me know if you like it or not, and if you would like anything changed.

Spatenheinz avatar Aug 02 '24 22:08 Spatenheinz

I can look into making it less confusing (although most of what i have done is to not repeat too much code between listing of a group and of a submodule), but looking at it again it can probably be done in a better way.

Regarding the --group, either I have completely misunderstood you or you shifted your opinion since I opened https://github.com/casey/just/issues/2195 :

https://github.com/casey/just/issues/2195#issuecomment-2192821668

Spatenheinz avatar Aug 05 '24 07:08 Spatenheinz

Yah I think looking at the implementation, and how much simpler just --list --group FOO would be made me change me ind.

casey avatar Aug 05 '24 07:08 casey

Sorry to flip flop!

casey avatar Aug 05 '24 07:08 casey

its all good. I will try and see to it.

Spatenheinz avatar Aug 05 '24 11:08 Spatenheinz