react-color icon indicating copy to clipboard operation
react-color copied to clipboard

Removed defaultProps.

Open ofps opened this issue 1 year ago • 14 comments

This PR removes defaultProps from every function component, solving issue #888 . Changes in package.json were needed to successfully build and test the project.

ofps avatar Nov 28 '23 19:11 ofps

I don't know if this was merged with the main branch but Installed this package and got the same error for checkboard and one more. Doesn't seen resolved.

Micode360 avatar Nov 30 '23 20:11 Micode360

Hi @Micode360

Thank you for your feedback.

If you installed this branch it's possible your version manager kept using the original since the version did not change.

I have successfully removed all warnings from one of my projects by using the main branch of my fork: fernandojpps/react-color, can you see if that works for you?

Let me know if that fixes the warnings for you.

There is another warning with the Checkboard component that this PR doesn't fix, it's related to the use of canvas to generate the checkboard, which only works on the client. I actually tested some solutions for that but I'm not happy with the results yet. That will probably be a future PR.

ofps avatar Dec 01 '23 11:12 ofps

@fernandojpps okay. I ended using another. But if I need it again, I will install it.

Micode360 avatar Dec 07 '23 18:12 Micode360

can anyone check this please?

fandredev avatar Apr 17 '24 09:04 fandredev

This PR removes defaultProps from every function component, solving issue #888 . Changes in package.json were needed to successfully build and test the project. How can I use this update? Could you provide specific guidance to help me? Thank you very much.

PhamMinhKha avatar May 06 '24 01:05 PhamMinhKha

bump

alxAgu avatar Jun 16 '24 02:06 alxAgu

This needs to be merged in order to keep up with react.

mxmp210 avatar Jun 17 '24 11:06 mxmp210

yes please

DarthSnufkin avatar Jun 19 '24 08:06 DarthSnufkin

@casesandberg Can we have this merged please? @fernandojpps Cn you provide a patch fix?

seemX17 avatar Jun 20 '24 16:06 seemX17

any updates?

clararabello avatar Jul 05 '24 15:07 clararabello

@casesandberg Can you take a look at this when you are free? I think it can be merged.

Thanks

rohitkrishna094 avatar Jul 11 '24 04:07 rohitkrishna094

begging

isaackogan avatar Aug 12 '24 01:08 isaackogan

interested in this getting merged also!

vicmassy avatar Aug 14 '24 10:08 vicmassy