Francesco Casella
Francesco Casella
Once we get a second review on #4541 this will be closed.
LTX needs to add reference results for this test. @MatthiasBSchaefer will take care of that.
> This introduces a new model in ModelicaTest, so this issue should only be closed once we have new reference results for that model. Here they are: https://github.com/modelica/MAP-LIB_ReferenceResults/tree/v4.1.0/ModelicaTest/Media/TestOnly/R134a_setState_phX
In the case of the Gain block I would be hesitant at adding default units, because in general the input and the output of that block could have different units....
> That is, setting `unit = "1"` for `k1` and `k2` would make it cumbersome to use the block with other units for these parameters. I'd argue that the sensible...
Adding @perost and @adrpo to the loop.
> @kabdelhak do you want to include that one or try to add the sparsity pattern? I see no reason why the NB shouldn't be using the sparsity pattern. Large...
Smaller version of the original MWE: [DistributionSystemModelicaIndividual_N_2_M_2.mo.txt](https://github.com/OpenModelica/OpenModelica/files/10765932/DistributionSystemModelicaIndividual_N_2_M_2.mo.txt)
You may also try this one ```modelica model TestSparsity Real a, b, c, d, e, f; equation 2*a + 3*b + 4*c = 10*time; -a + 5*b + 6*c =...
> @casella this is alias removal, not actual tearing. If you have a linear equation with no more than two variables, it will be used for alias removal. Or at...