Francesco Casella comments

Results 1726 comments of


                                            Francesco Casella

Inconsistent handling of $cse expressions in models involving interpolate() and state variable change

@phannebohm, @kabdelhak, I tried this with the NB and I got this: ``` [1] 17:46:54 Translation Error Internal error NBSlice.fillDependencyArray failed because number of flattened indices 1 for dependency $DER.M...

The more classes you have instantiated, the longer it takes to instantiate another one.

@adeas31 this looks potentially serious, please have a look at it ASAP.

The more classes you have instantiated, the longer it takes to instantiate another one.

@adeas31, @perost, I am still wondering why this `SingleAxis` model should contain so much information (40 MB worth of JSON stuff, according to this [comment](https://github.com/OpenModelica/OpenModelica/issues/10436#issuecomment-1482662610)) that it takes 15 seconds...

The more classes you have instantiated, the longer it takes to instantiate another one.

> We dump everything that OMEdit needs, not just for drawing the diagrams but also for e.g. parameter editing, replaceable, and so on Sure, but it can't be 40 MB....

The more classes you have instantiated, the longer it takes to instantiate another one.

OK, I see ``` Time for "getModelInstance(Rexroth_BRSL.Examples.Systems.SingleAxis)" 9.738 secs Time for converting to JSON 0.37 secs Time for parsing JSON 6.649 secs Time for drawing graphical objects 0.111 secs ```...

The more classes you have instantiated, the longer it takes to instantiate another one.

> 9.738 is the time for instantiation. Ah, ok. I thought getModelInstance also included the JSON processing. > Also note that this varies based on the OS. On Windows it...

The more classes you have instantiated, the longer it takes to instantiate another one.

I flattened the `Rexroth_BRSL.Examples.Systems.SingleAxis model` in OMEdit and looked into it. The model has about 5000 variables, and over 30,000 scalar parameters (!!). Most of them are final. I guess...

The more classes you have instantiated, the longer it takes to instantiate another one.

Maybe we could do some profiling again after the latest commits and see what the current bottlenecks are. @adeas31 could you take care of that?

The more classes you have instantiated, the longer it takes to instantiate another one.

See the plan in #11920. Removing components, adding and removing connections will be fast in 1.23.0. Adding new components will take more time, we now have a plan are working...

Failing Models in ClaRa

[ClaRa](https://libraries.openmodelica.org/branches/master/ClaRa/ClaRa.html) should test the latest released version (currently [1.8.1](https://github.com/xrg-simulation/ClaRa-official/releases)), while [ClaRa_dev](https://libraries.openmodelica.org/branches/master/ClaRa_dev/ClaRa_dev.html) should test the HEAD revision on the master branch. For some reason, they instead both test HEAD/main, currently at...