ThermoPower
ThermoPower copied to clipboard
casella
A Modelica library for thermal power generation system modelling
Here, `partialArc` is used in an equation: https://github.com/casella/ThermoPower/blob/d028b9ee4ba18ff148726fffe50917de29102a0b/ThermoPower/PowerPlants.mo#L13459 It is declared here as a conditional component: https://github.com/casella/ThermoPower/blob/d028b9ee4ba18ff148726fffe50917de29102a0b/ThermoPower/Water.mo#L6028 This is [illegal Modelica](https://specification.modelica.org/maint/3.6/class-predefined-types-and-declarations.html#conditional-component-declaration): > A component declared with a condition-attribute can only...
The examples inside `ThermoPower.Examples.CISE.Simulators` all extend `Modelica.Icons.Example` first, and then another class like `Models.CISESim` which specifies the example and the diagram extent. Since the diagram extent is picked [from the...
In these two lines, `==` is used on Reals, which is not legal Modelica: https://github.com/casella/ThermoPower/blob/d028b9ee4ba18ff148726fffe50917de29102a0b/ThermoPower/Water.mo#L3856-L3858
Here's my attempt at converting ThermoPower to MSL 4, just in case you find it useful.
Introducing replaceable model for friction computation in place of the FFType enumeration, while keeping backwards-compatibility
Hello, I have been getting familiar with the HeatExchangerWater model located in ThermoPower/Examples/HRB/Models for the past few weeks. The model I am using to test the HeatExchanger is running properly,...
There are duplicated declarations of `g` in `ThermoPower.Water.Flow1Dfem2ph`. Output from System Modeler: ``` Error: ThermoPower.Water.Flow1Dfem2ph [1:5-1:5] Invalid class definition. Element g is duplicated, but its definitions are not identical. constant...
The examples in `ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE*` (and classes they depend on) reference identifiers that do not exist. These are diagnostic outputs from System Modeler: ``` [3] 16.46 Validation of model ThermoPower.PowerPlants.ElectricGeneratorGroup.Tests.Test_Generator_SE Error:...
…ad of PartialPureSubstance. I think this is needed to be coherent with the pTXs functions used.
I'm trying to get the brayton cycle example to work so I can try testing the compressor but I keep getting the same error when I run the closed loop...
