cascade icon indicating copy to clipboard operation
cascade copied to clipboard

support this plugin

Open sankemao opened this issue 2 years ago • 12 comments

i have found this plugin : https://addons.mozilla.org/en-GB/firefox/addon/adaptive-tab-bar-color/ and i think it will be more awsome if this theme can change tabbar color

sankemao avatar May 17 '22 14:05 sankemao

Known Issues Does not support CSS themes

I'll def. give this a shot, but I don't really have high hopes of getting this to work as the Readme already states that it doesn't work with custom CSS. :c

unseen-ninja avatar May 18 '22 07:05 unseen-ninja

I've played around with the plugin a little more and it's actually possible to make it work with Cascade as well. The only issue: Firefox keeps crashing consitently with the plugin enabled. I haven't checked out this bevahiour without Cascade, but my assumption is that it's not the custom CSS causing the issue here, but the plugin itself. So that's something to keep in mind.

unseen-ninja avatar Jun 05 '22 00:06 unseen-ninja

@andreasgrafen out of curiosity what edits did you attempt, I'd like to dig more into this. It would be great if you make an adaptive branch (or just throw it in experimental)

RaafatTurki avatar Jul 04 '22 12:07 RaafatTurki

It seems to work when you just strip out all colour definitions. Tho it's glitchy from time to time.

I could actually throw some of the alternatives I've explored over time into the Repo. Not too bad of an Idea! I'll prob. do that with the next set of changes. c:

unseen-ninja avatar Jul 04 '22 14:07 unseen-ninja

Just so we're on the same page, I've stripped the colors out like so: image

And now my firefox looks like my gtk theme, however there are some opacity issues that didn't exist before: transparent alert message image tabs have no background hence tab names overlap when dragging image

And after installing the Adaptive Tab Bar Color extension all hell broke loose (navbar and search suggestions went full transparent) image

On the bright side none of the crashed you've mentioned occurred to me. I'd really appreciate some feedback here, Did I strip the colors the same way you did? Iet me know what you think.

RaafatTurki avatar Jul 04 '22 15:07 RaafatTurki

Not quite, I've just revisited this and it's actually enough to remove line 238 as well as lines 275 to 288 c:

I might have formulated my initial answer a little misleading. :/

unseen-ninja avatar Jul 04 '22 16:07 unseen-ninja

Ah, That's more like it, no crashes as well, big thanks!

One thing is I've noticed the elements that get effected by the 3 main color definitions change depending on if the plugin is installed on not

--window-colour:                     #1E2021;
--secondary-colour:                  #191B1C;
--inverted-colour:                   #FAFAFC;

I haven't looked into the other colors.

RaafatTurki avatar Jul 04 '22 16:07 RaafatTurki

Oh, right! I totally forgot to check that.. You might be able to get away with removing lines 444 to 451 to fix the urlbar popout colours. Tho.. I haven't tested how that behaves.

unseen-ninja avatar Jul 04 '22 17:07 unseen-ninja

Actually doing that results in the same opacity issue in the last image above.

RaafatTurki avatar Jul 04 '22 17:07 RaafatTurki

nyeh.. What happens if you additionally remove lines 438 to 441?

Maybe even line 417.

unseen-ninja avatar Jul 04 '22 17:07 unseen-ninja

Yeah that fixes it, I'm noticing a lot of pieces were removed in order to make this happen, maybe split the style sheets and let the user require the parts that fit their needs?

This would work great for colors as well since users could update cascade and keep their custom colors

RaafatTurki avatar Jul 04 '22 19:07 RaafatTurki

Yeah. That's a long term plan I haven't implemented yet.. Tho, I'm currently working on a complete rewrite of Cascade anyway. So that will come for sure! c:

unseen-ninja avatar Jul 04 '22 21:07 unseen-ninja

Heya … it has been quite a while but I finally got around to implement all the things I wanted into a reworked version of Cascade. If you're still interested in this you could check out the rework branch and just remove the colours include from the main file to ensure you're using the system colour. I've done some quick testing and on my end it works quite well with this plugin. c:

unseen-ninja avatar Oct 14 '22 21:10 unseen-ninja