node-casbin icon indicating copy to clipboard operation
node-casbin copied to clipboard

Published 20 hours ago • verified publisher icon casbin

Wrong method in multiline parsing

Open moshekar opened this issue 2 years ago • 4 comments

Hi,

Multiline parsing in config.ts is using .includes(), but should use .endsWith(), as the multiline separator is valid only at the end of the line. https://github.com/casbin/node-casbin/blob/7803ccbd4cc25e2faac9b508ef57ebee2f8d5750/src/config.ts#L127

Thanks.

moshekar avatar Mar 27 '22 14:03 moshekar

@Gabriel-403 @Zxilly @kingiw @nodece

casbin-bot avatar Mar 27 '22 14:03 casbin-bot

@moshekar can you make a PR to fix it?

hsluoyz avatar Mar 28 '22 00:03 hsluoyz

@moshekar can you make a PR to fix it?

Done: PR #355 Thanks.

moshekar avatar Mar 28 '22 08:03 moshekar

@moshekar maybe create a pr again? as you may already know semantic pr was required for release.

Shivansh-yadav13 avatar Apr 03 '22 15:04 Shivansh-yadav13

@hsluoyz can I make PR to this issue, is it still open?

PrathamJaiswal001 avatar Jan 09 '23 17:01 PrathamJaiswal001

@PrathamJaiswal001 sure

hsluoyz avatar Jan 10 '23 05:01 hsluoyz

:tada: This issue has been resolved in version 5.20.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jan 10 '23 12:01 github-actions[bot]