jcasbin icon indicating copy to clipboard operation
jcasbin copied to clipboard

feat: reimplement default role manager

Open seriouszyx opened this issue 1 year ago • 4 comments

Fix: https://github.com/casbin/jcasbin/issues/261

Signed-off-by: Yixiang Zhao [email protected]

seriouszyx avatar Jul 22 '22 08:07 seriouszyx

@tangyang9464 @imp2002 please review

casbin-bot avatar Jul 22 '22 08:07 casbin-bot

@tangyang9464

hsluoyz avatar Jul 22 '22 13:07 hsluoyz

Codecov Report

Merging #285 (04706d3) into master (51d1294) will increase coverage by 1.31%. The diff coverage is 93.24%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   66.75%   68.07%   +1.31%     
==========================================
  Files          45       47       +2     
  Lines        2262     2371     +109     
  Branches      394      405      +11     
==========================================
+ Hits         1510     1614     +104     
- Misses        633      643      +10     
+ Partials      119      114       -5     
Impacted Files Coverage Δ
...n/java/org/casbin/jcasbin/util/SyncedLRUCache.java 90.00% <90.00%> (ø)
...in/java/org/casbin/jcasbin/rbac/DomainManager.java 91.35% <91.35%> (ø)
...va/org/casbin/jcasbin/rbac/DefaultRoleManager.java 92.23% <93.67%> (+8.71%) :arrow_up:
src/main/java/org/casbin/jcasbin/rbac/Role.java 94.64% <95.45%> (+4.89%) :arrow_up:
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 79.19% <100.00%> (ø)
...java/org/casbin/jcasbin/util/BuiltInFunctions.java 86.48% <100.00%> (+0.67%) :arrow_up:
...rc/main/java/org/casbin/jcasbin/util/LRUCache.java 100.00% <100.00%> (ø)
...jcasbin/exception/CasbinNameNotExistException.java 0.00% <0.00%> (-100.00%) :arrow_down:
src/main/java/org/casbin/jcasbin/util/Util.java 58.24% <0.00%> (-3.30%) :arrow_down:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Jul 28 '22 07:07 codecov-commenter

@tangyang9464

hsluoyz avatar Jul 28 '22 13:07 hsluoyz

:tada: This PR is included in version 1.26.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 11 '22 16:08 github-actions[bot]