casbin-hub icon indicating copy to clipboard operation
casbin-hub copied to clipboard

Casbin model syntax and semantics check on Dashboard UI

Open hsluoyz opened this issue 4 years ago • 12 comments

Casbin dashboard has a page for models. We want to check whether the user has written a correct Casbin model or not. If it has syntax error, we want to prompt the error line and error reason. Just like IDE showing compile errors for languages like C++ or Java.

The syntax and semantics check can be done by frontend (like codemirror) or backend (run it on a Golang casbin enforcer) or mix the above two ways.

hsluoyz avatar Mar 22 '20 15:03 hsluoyz

I would like to work on this

shakti97 avatar Mar 24 '20 00:03 shakti97

Hi @hsluoyz I wanted to implement the validations but I am not getting how will I understand what is a valid Casbin Model? Is there any docs to help out?

techguybiswa avatar Mar 26 '20 08:03 techguybiswa

See our docs: https://casbin.org/docs/en/syntax-for-models

hsluoyz avatar Mar 28 '20 10:03 hsluoyz

Thanks yang, Will try to implement it

shakti97 avatar Mar 28 '20 10:03 shakti97

@hsluoyz Please check the PR at https://github.com/casbin/casbin-dashboard/pull/68 And please do let me know if my implementation is in the correct direction.

Thanks

techguybiswa avatar Mar 29 '20 22:03 techguybiswa

@hsluoyz Is this issue still open for work?

arteevraina avatar Sep 16 '20 15:09 arteevraina

@arteevraina yes.

hsluoyz avatar Sep 17 '20 08:09 hsluoyz

I am working on this.

arteevraina avatar Sep 17 '20 08:09 arteevraina

@hsluoyz Should this feature be implemented on this page? image

arteevraina avatar Sep 24 '20 12:09 arteevraina

@arteevraina you can ask @438561537

hsluoyz avatar Sep 24 '20 13:09 hsluoyz

Yes, I am working on this.@arteevraina

Xiaoyang-Gu avatar Sep 24 '20 13:09 Xiaoyang-Gu

Yes, I am working on this.@arteevraina

Ok Cool!

arteevraina avatar Sep 24 '20 13:09 arteevraina