casbin-cpp icon indicating copy to clipboard operation
casbin-cpp copied to clipboard

Add casbin-cpp to vcpkg

Open shishirong opened this issue 2 years ago • 7 comments

Description

I issued in vcpkg,but closed by someone. Have a expert to reopen or Pull requests about casbin-cpp.

shishirong avatar Nov 25 '22 09:11 shishirong

@EmperorYP7 @sheny1xuan @cs1137195420

casbin-bot avatar Nov 25 '22 09:11 casbin-bot

I try again https://github.com/microsoft/vcpkg/issues/28976

PokIsemaine avatar Jan 16 '23 02:01 PokIsemaine

see: https://github.com/microsoft/vcpkg/pull/29027

nomeguy avatar Jan 30 '23 01:01 nomeguy

The issue was closed again, it looks like the way casbin-cpp is installed by CMake is causing some difficulty adding to vcpkg. Can anyone fix this problem and open this issue again?

PokIsemaine avatar Jan 30 '23 02:01 PokIsemaine

To clarify, we didn't identify a specific problem with what casbin-cpp does; only that the generated instructions did not appear to match the user instructions in https://github.com/casbin/casbin-cpp which meant that the supplied portfile.cmake didn't install the right bits for users to use.

The author of that PR, @ex-purple said:

I figured out what's wrong Library and CMake configuration are installed in the CMake User Package Registry.

I don't know what "CMake User Package Registry" means; it certainly isn't a thing understood by vcpkg. The port just needs to install the right configs or similar to ${CURRENT_PACKAGES_DIR}/share/${PORT} so that find_package works for downstream customers.

BillyONeal avatar Feb 01 '23 00:02 BillyONeal

Look here System installation (install command) is present only for headers. Library and cmake configuration are exported to the CMake User Package Registry.

CMake User Package Registry it is user specific installation. vcpkg works with system installation, so we have only headers for the vcpkg port

ex-purple avatar Feb 01 '23 10:02 ex-purple

@ex-purple Thanks for your help, I would like to see if casbin-cpp needs to be changed to make it successfully added to vcpkg. If necessary, you can consider submitting a PR to casbin-cpp, which is grateful.

PokIsemaine avatar Feb 18 '23 08:02 PokIsemaine