jumpcutter icon indicating copy to clipboard operation
jumpcutter copied to clipboard

Three issues I need to point out.

Open HaujetZhao opened this issue 4 years ago • 6 comments

  1. pytube is no longer supported. New users need to install pytube3 by pip3 install pytube3 , new users, be aware of that.
  2. this script will amplify my audio, which will also increase the background noise, which annoies me.
  3. Those files whose path have space key can not be supported.

Except that, this project is so damn amazing! amazing!!!!!!!!!!!!!! I'm so excited!!!

HaujetZhao avatar Mar 17 '20 11:03 HaujetZhao

Hey @JackalZhao, we're working on these currently!

Support for YouTube is a lesser focus, but audio is a top priority. We are also quite annoyed that spaces in file paths causes issues, but we are looking for solutions.

Right now we are debating adding naming logic to remove spaces in the tmp dir, then reapplying spaces after completion.

If you have time to help us make this product into something even better, you should join Cary's JumpCutter discord server.

Peter, I, and the rest of the team would love to hear your input and work with you.

Dreiparrent avatar Mar 22 '20 20:03 Dreiparrent

name space is already solved, see my newest issue or newest pull.

I also wrote another version, in my fork jumpcutter,  which solved a big problem:  when a video is too long, the jumped her will crash,  because it stores all the raw audio data in the memory with float64,yeah my computer if a video is more than 10 minutes,jumpcutter will crush because of lacking memory, so I stored that data in the disk, so it won't crash  even if you have a very long video.  but many of the comments are Chinese for my convenience in my fork, you can delete and replace them for your convinience。

HaujetZhao avatar Mar 22 '20 23:03 HaujetZhao

name space is already solved, see my newest issue or newest pull.

I also wrote another version, in my fork jumpcutter,  which solved a big problem:  when a video is too long, the jumped her will crash,  because it stores all the raw audio data in the memory with float64,yeah my computer if a video is more than 10 minutes,jumpcutter will crush because of lacking memory, so I stored that data in the disk, so it won't crash  even if you have a very long video.  but many of the comments are Chinese for my convenience in my fork, you can delete and replace them for your convinience。

sorry to necro but how did you get past the crash due to lack of memory ? i know a solution is to clip the file into smaller chunks before hand but wondering if there is a simpler solution

callmedougan avatar Mar 30 '20 09:03 callmedougan

@callmedougan commented on Mar 30, 2020, 2:47 AM PDT:

sorry to necro but how did you get past the crash due to lack of memory ? i know a solution is to clip the file into smaller chunks before hand but wondering if there is a simpler solution

Do you have 64-bit Python installed? 32-bit limits the amount of memory that can be used.

vuongmason avatar Apr 01 '20 13:04 vuongmason

@callmedougan commented on Mar 30, 2020, 2:47 AM PDT:

sorry to necro but how did you get past the crash due to lack of memory ? i know a solution is to clip the file into smaller chunks before hand but wondering if there is a simpler solution

Do you have 64-bit Python installed? 32-bit limits the amount of memory that can be used.

im rolling 32-bit python (somehow the idea of a 64bit python passed me by - annoyed at myself for missing that)

callmedougan avatar Apr 01 '20 16:04 callmedougan

@callmedougan commented on Mar 30, 2020, 2:47 AM PDT:

sorry to necro but how did you get past the crash due to lack of memory ? i know a solution is to clip the file into smaller chunks before hand but wondering if there is a simpler solution

Do you have 64-bit Python installed? 32-bit limits the amount of memory that can be used.

im rolling 32-bit python (somehow the idea of a 64bit python passed me by - annoyed at myself for missing that)

I just saved the small chunks into wav file, stored them in the disk. After that, when concating, I use ffmpeg concat format.

HaujetZhao avatar Apr 02 '20 07:04 HaujetZhao