jumpcutter icon indicating copy to clipboard operation
jumpcutter copied to clipboard

FFMPEG is used from cmdline, switch to the ffmpeg module instead

Open rizerphe opened this issue 5 years ago • 3 comments

FFMPEG should not be used with the 'subprocess' module because it introduces some problems if, for example, video name contains spaces. It can also cause some issues if the vid name is, for example, vid.mp4; sudo rm -r /home.

Switch to ffmpeg-python or something instead.

rizerphe avatar Feb 07 '20 17:02 rizerphe

I'm already working on implementing that in a fork...

rizerphe avatar Feb 07 '20 17:02 rizerphe

Pull request added

rizerphe avatar Feb 07 '20 19:02 rizerphe

Nice quality improvements. As you can see there are quite many pull requests. The reason is that @carykh doesn't seem to have the time to maintain it and did not react to issue #148 yet.

Lamaun avatar Feb 08 '20 14:02 Lamaun