VirusGame icon indicating copy to clipboard operation
VirusGame copied to clipboard

Change particles to make them look more distinct for people with colorblindness

Open drherobrine opened this issue 4 years ago • 11 comments

There is an issue about the food and waste particles being too similar to tell apart for people with colorblindness, so I made a small fix to help with that.

drherobrine avatar Aug 16 '20 15:08 drherobrine

There are a lot of weird unnecessary whitespace changes in your PR.

MaPePeR avatar Aug 16 '20 18:08 MaPePeR

There are a lot of weird unnecessary whitespace changes in your PR.

I don't get what you mean?

drherobrine avatar Aug 16 '20 18:08 drherobrine

Click on "Files changed" or at the commit.

The commit says you changed the whole file, even though you only changed a few lines.

MaPePeR avatar Aug 16 '20 19:08 MaPePeR

My guess is Windows did its newline shenanigans which changed all normal newlines to their weird newlines

friedkeenan avatar Aug 16 '20 20:08 friedkeenan

My guess is Windows did its newline shenanigans which changed all normal newlines to their weird newlines

Well, I'm running Ubuntu so not sure if that's it

drherobrine avatar Aug 16 '20 20:08 drherobrine

Maybe the other way around then, Ubuntu changing the weird Windows newlines to normal ones

friedkeenan avatar Aug 16 '20 21:08 friedkeenan

You should try and fix the line endings to increase your chances of the PR being merged.

BLiu1 avatar Aug 17 '20 04:08 BLiu1

@BLiu1 how would I do that?

drherobrine avatar Aug 17 '20 15:08 drherobrine

@drherobrine Make another commit in your repo where you undo the line endings.

FranchuFranchu avatar Aug 17 '20 15:08 FranchuFranchu

Ok, turns out the \r\n got converted to \n somewhere along the way. Should be sorted out now,

drherobrine avatar Aug 17 '20 16:08 drherobrine

Oops, clicked the wrong button

drherobrine avatar Aug 17 '20 17:08 drherobrine