kapp icon indicating copy to clipboard operation
kapp copied to clipboard

Patch resource history annotations instead of update

Open rcmadhankumar opened this issue 2 years ago • 2 comments

What this PR does / why we need it:

Patch resource history annotations instead of update which can avoid updating the entire resource while adding the resource history annotation.

Which issue(s) this PR fixes:

Fixes #472

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • [ ] Follows the developer guidelines
  • [ ] Relevant tests are added or updated
  • [ ] Relevant docs in this repo added or updated
  • [ ] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
  • [ ] Code is at least as readable and maintainable as it was before this change

Additional documentation e.g., Proposal, usage docs, etc.:

NONE

rcmadhankumar avatar Oct 05 '23 11:10 rcmadhankumar

Are we still planning on putting this change in?

100mik avatar Feb 13 '24 08:02 100mik

Are we still planning on putting this change in?

We do want to, the only reason we didn't do it yet is because some tests were failing in an older version of k8s and we couldn’t figure out the reason even after doing some investigation.

praveenrewar avatar Feb 14 '24 06:02 praveenrewar