bug fix: app metadata file should write to disk even when deploy fails

[DennisDenuto]

trafficstars

What this PR does / why we need it:

bug fix when kapp deploy fails. Continue to write out the app metadata file with the latest state change. (Instead of not writing out a file when a deploy fails)

Additional Notes for your reviewer:

Review Checklist:

• [x] Follows the developer guidelines
• [x] Relevant tests are added or updated
• [x] Relevant docs in this repo added or updated
• [x] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
• [ ] Code is at least as readable and maintainable as it was before this change

Additional documentation e.g., Proposal, usage docs, etc.: