Print success message to stderr

[jvassev]

The string "Succeeded" confuses tools that parse the output.

For example, you couldn't do eval "$(kapp completion bash)" without the error Succeeded: command not found.

Maybe don't even bother with this message and output "Error" only when unsuccessful?

[vmwclabot]

@jvassev, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[vmwclabot]

@jvassev, VMware has approved your signed contributor license agreement.

[cppforlife]

PR seems reasonable. it seems like there is a failing test.

[joaopapereira]

Hello @jvassev looks like that you just need to correct one test, and from the looks of it you just need to remove the following lines: https://github.com/vmware-tanzu/carvel-kapp/blob/develop/test/e2e/order_test.go#L121 https://github.com/vmware-tanzu/carvel-kapp/blob/develop/test/e2e/order_test.go#L122 https://github.com/vmware-tanzu/carvel-kapp/blob/develop/test/e2e/order_test.go#L206 https://github.com/vmware-tanzu/carvel-kapp/blob/develop/test/e2e/order_test.go#L207

and everything should be ready to merge

[praveenrewar]

Closing this as we no longer print the Succeeded message for bash completion command. Please feel free to reopen in case you feel that this is still required.