kapp-controller
kapp-controller copied to clipboard
Packaging kapp-controller with kctrl
What this PR does / why we need it:
Packaging kapp-controller with kctrl
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
- [ ] Follows the developer guidelines
- [ ] Relevant tests are added or updated
- [ ] Relevant docs in this repo added or updated
- [ ] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
- [ ] Code is at least as readable and maintainable as it was before this change
Additional documentation e.g., Proposal, usage docs, etc.:
@sethiyash Can you make the changes we discussed so that we dont end up generating 2 images with different sha sum for same release.
Just popping to in to say that it's pretty cool that we package kapp-controller
with its own kctrl
. Also, it serves as a good in-the-wild example for packaging with kctrl
. Good things all around! 🎉
Hey @sethiyash ! Now that https://github.com/vmware-tanzu/community-edition/ has been officially retired. It's important that we publish our own package for consumption by Tanzu and the community at large. So happy to help review / get this to a place where we can merge it in soon. (there's no emergency here, just want to make sure you have the support you need)
@sethiyash Do you think we should add a test like installing kapp-controller
to ensure that generated package installs successfully before the github action exits?
@sethiyash Do you think we should add a test like installing kapp-controller to ensure that generated package installs successfully before the github action exits?
Challenge here is to install kapp-controller package I need kapp-controller to be installed and after installing kapp-controller if I install it through its Package it will through ownership error as kapp-controller already exists.
Merged this away as we would like a Package with the next release.
Next steps would be, having something config-dev
which works with kctrl, that would help a lot with local dev for the package if we make changes to the process at some point.
A test which reconciles the generated package using kctrl dev
while adding a PackageInstall and RBAC on the fly would be awesome!