kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Namespace isolation

Open showpune opened this issue 3 years ago • 1 comments

What this PR does / why we need it:

When to start the kapp-controller, two start options are added

  1. start-api-server with boolean type indicate if start the api server 2_ namespace with string to indicate which namespace will be reconciled In a cluster, we will start multiple reconcile controller in each namespace to reconcile the resource in the specific namespace, but only keep one to run the api server

Which issue(s) this PR fixes:

Fixes #792

Does this PR introduce a user-facing change?

When to start the kapp-controller, two start options are added
1) start-api-server with boolean type indicate if start the api server in the instance
2_ namespace with string to indicate which namespace will be reconciled
In a cluster, we will start multiple reconcile controller in each namespace to reconcile the resource in the specific namespace, but only keep one to run the api server

Additional Notes for your reviewer:

Review Checklist:
  • [X] Follows the developer guidelines
  • [X] Relevant tests are added or updated
  • [ ] Relevant docs in this repo added or updated
  • [ ] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
  • [X] Code is at least as readable and maintainable as it was before this change

Additional documentation e.g., Proposal, usage docs, etc.:


showpune avatar Aug 12 '22 05:08 showpune

@showpune, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Aug 12 '22 05:08 vmwclabot

@showpune, VMware has approved your signed contributor license agreement.

vmwclabot avatar Aug 16 '22 14:08 vmwclabot