kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Support secret key in AppTemplateValuesSourceRef

Open jessehu opened this issue 3 years ago • 2 comments

Describe the problem/challenge you have We want to use a shared Secret across Package CRs, and use different keys in the Secret for different Package CRs.

Describe the solution you'd like Add 'key' field in AppTemplateValuesSourceRef just like AppClusterKubeconfigSecretRef https://github.com/vmware-tanzu/carvel-kapp-controller/blob/7d7ea1d65be1034906aca0145b895627ed4e233c/pkg/apis/kappctrl/v1alpha1/types.go#L92-L99

Anything else you would like to add: [Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

jessehu avatar Jul 13 '22 01:07 jessehu

Thanks @jessehu - independent of future development in kapp-controller, we think you could potentially solve this problem with existing tools today by using the "secrets template" feature in secretgen controller to re-shape the original secret for each app (though that solution will add a few extra steps).

It sounds like we'll work on this eventually but I guess you and others are free to argue it to bump it in priority and/or try your hand(s) at contributing this feature.

joe-kimmel-vmw avatar Jul 18 '22 18:07 joe-kimmel-vmw

Thanks Joe. This feature request is not high priority for us. We have a work around. I will see if we can make the contribution.

jessehu avatar Jul 19 '22 03:07 jessehu