kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Document helm template name and namespace annotations

Open jorgemoralespou opened this issue 4 years ago • 3 comments

There's 2 experimental annotations that helps helmTemplate processing to define the name and namespace, but these are not documented: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/22d3f3a23048f41b9dc7e9c56944ef67c2819758/pkg/packageinstall/app.go#L24-L25

They should be in the docs.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

jorgemoralespou avatar Apr 19 '22 15:04 jorgemoralespou

Thanks @jorgemoralespou -

The team that's working in this codebase now didn't write those annotations and we just learned about them through this ticket as well!

Would you describe them something like this:?

These annotations allow the package consumer to override the name and namespace that will be passed to the helm chart.

joe-kimmel-vmw avatar Apr 20 '22 16:04 joe-kimmel-vmw

That seems like it, but you should ask the person that added the annotations, and not me :-D

jorgemoralespou avatar Apr 20 '22 16:04 jorgemoralespou

it looks like there's some descriptions in this issue: https://github.com/vmware-tanzu/carvel-kapp-controller/issues/409

joe-kimmel-vmw avatar Apr 20 '22 18:04 joe-kimmel-vmw

@joe-kimmel-vmw was this ever documented?

neil-hickey avatar Feb 22 '23 18:02 neil-hickey