kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Change copyright notices to Carvel Authors

Open bentito opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

Change copyright notices to Carvel Authors in every file there was already a copyright header.

Which issue(s) this PR fixes:

Fixes #1503

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • [ ] Follows the developer guidelines
  • [ ] Relevant tests are added or updated
  • [ ] Relevant docs in this repo added or updated
  • [ ] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
  • [ ] Code is at least as readable and maintainable as it was before this change

Additional documentation e.g., Proposal, usage docs, etc.:

None

I created a script with logging to make these changes. The log for all the Carvel repo changes is here: https://gist.github.com/bentito/c39c38282dd4c856a79f8adb7394180e NB: vendor dirs are all ignored as are any non go, py, js, cpp, or c files, though I think in practice there were only copyright headers on .go files.

bentito avatar Mar 14 '24 12:03 bentito

Hello @bentito,

Thank you so much for submitting this pull request! Your contributions are greatly appreciated.

The changes you've made to the files look fantastic. I've had a chance to review them, and everything seems to be in order.

I noticed that we also have a GitHub action in place that checks for the Go header based on this template. It would be wonderful if we could modify this template to reflect The Carvel Authors instead of VMware.

If you need any assistance or guidance along the way, please don't hesitate to reach out. I look forward to collaborating with you further!

sethiyash avatar Mar 19 '24 10:03 sethiyash

Hello @bentito,

Thank you so much for submitting this pull request! Your contributions are greatly appreciated.

The changes you've made to the files look fantastic. I've had a chance to review them, and everything seems to be in order.

I noticed that we also have a GitHub action in place that checks for the Go header based on this template. It would be wonderful if we could modify this template to reflect The Carvel Authors instead of VMware.

If you need any assistance or guidance along the way, please don't hesitate to reach out. I look forward to collaborating with you further!

@sethiyash ok, made the change.

bentito avatar Mar 25 '24 17:03 bentito

@sethiyash I think this might be all set to merge now?

bentito avatar Mar 27 '24 20:03 bentito