kapp-controller icon indicating copy to clipboard operation
kapp-controller copied to clipboard

Published 20 hours ago • verified publisher icon carvel-dev

Making CRDAppFactory an interface

Open sethiyash opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

Which issue(s) this PR fixes:

#1494

Fixes #

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:
  • [ ] Follows the developer guidelines
  • [ ] Relevant tests are added or updated
  • [ ] Relevant docs in this repo added or updated
  • [ ] Relevant carvel.dev docs added or updated in a separate PR and there's a link to that PR
  • [ ] Code is at least as readable and maintainable as it was before this change

Additional documentation e.g., Proposal, usage docs, etc.:

sethiyash avatar Feb 26 '24 10:02 sethiyash

@jorgemoralespou, Is this what you are looking for?

sethiyash avatar Feb 26 '24 15:02 sethiyash

Yes. Thank you for getting to this so fast.

jorgemoralespou avatar Feb 26 '24 15:02 jorgemoralespou

LGTM

prembhaskal avatar Mar 20 '24 05:03 prembhaskal