pull command should indicate why images.yml was not localized

[cppforlife]

Describe the problem/challenge you have currently imgpkg just says images.yml was not localized. it's not clear why it was not -- we should probably include underlying error/reason and related image. probably should give a reason even if it was successful.

this would have been handy when we were trying to figure out why images.yml was not coming back rewritten after imgpkg copy used (problem was some images were returning denied).

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

[joaopapereira]

I looked through the piece of code and what is being done right now is failing fast, we are not checking all images.

We could eventually change the current behavior and get some better messaging.

This is the current output

Pulling bundle 'localhost:5000/test@sha256:887d31056ad405b4172a49caf204dc5f3034905c83aa43f754f78740f709739c'
  Extracting layer 'sha256:95f77ce99d4a3bb259627e60d740ba8dffc7e24dda95db15573a85b7cb64ee1e' (1/1)

Locating image lock file images...
One or more images not found in bundle repo; skipping lock file update

Succeeded

Is your suggestion something like:

Pulling bundle 'localhost:5000/test@sha256:887d31056ad405b4172a49caf204dc5f3034905c83aa43f754f78740f709739c'
  Extracting layer 'sha256:95f77ce99d4a3bb259627e60d740ba8dffc7e24dda95db15573a85b7cb64ee1e' (1/1)

Locating image lock file images...
Skipping lock file update because
- index.docker.io/user/image1@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a000 (Could not be found)
- index.docker.io/user/image2@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a000 (Unauthorized access)

Succeeded

[cppforlife]

what is being done right now is failing fast, we are not checking all images.

@joaopapereira still want to do that. just would like to see reason for the first failure.

[joaopapereira]

I agree with that. So in order to keep the behavior this is my new proposal for UX

Pulling bundle 'localhost:5000/test@sha256:887d31056ad405b4172a49caf204dc5f3034905c83aa43f754f78740f709739c'
  Extracting layer 'sha256:95f77ce99d4a3bb259627e60d740ba8dffc7e24dda95db15573a85b7cb64ee1e' (1/1)

Locating image lock file images...
Skipping lock file update because
- index.docker.io/user/image2@sha256:4c8b96d4fffdfae29258d94a22ae4ad1fe36139d47288b8960d9958d1e63a000 (Unauthorized access)

Succeeded

Going to accept this issue