Phillip Carter

Results 640 comments of Phillip Carter

My guess is it has to do with this addition. Frankly, there's probably no need for it: https://github.com/dotnet/fsharp/pull/9563/files#diff-2a492c131c46adf510ae8bfb8a1c1fa1d1392a8c0ea0ed9bf9177f86dff16599R1168

@dsyme this is a language suggestion / in the right repo already 🙂

Yes, this is likely related to https://github.com/dotnet/fsharp/issues/4832 but I don't think it's the same issue. I imagine we're just not pulling in the names during name resolution when we should,...

Ahhhh, if only this were the default in F# 1.x (and this attribute, or maybe named `Inheritable` or something). I think I'd probably not be in favor because it's an...

> You always needed to know contents of each file before this one (defined types, shadowing, overloads) and contents of project file (target framework, language version and references). You absolutely...

I think it makes plenty of sense, for the reasons stated. Opaque changes are not generally good to make.

@auslavs which VS version are you using? Does this also reproduce in release?

I think maybe you just need to bump the global.json and the github runners?

Ugh. So I'm pretty sure this is a FAKE issue: https://github.com/fsprojects/FAKE/issues/2753