Phillip Carter
Phillip Carter
Tentatively labeling as a bug. Although we're respecting the configuration during conversion, the fact that the project system isn't picking it up likely implicates try-convert in doing something subtly wrong.
Thanks @MadEste!
@Chelaris182 could you clarify what you mean by this? > Transitive dependencies can be removed with VS if they haven't been yet moved to csproj. You can manually remove these...
Hey @sqeezy can you verify that this still happens with the latest version of the tool? The error would indicate that you don't have an appropriate MSBuild installed. Is Visual...
would you happen to know if the project you're converting specifies a specific version of an msbuild toolset? e.g. like this https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-toolset-toolsversion?view=vs-2019 If so, what happens if you remove it?
That's my signal to my future self to say, "Hey, you should really think about this" It'll probably mean using ILogger tho
I'd need to defer to @jmarolf on what the best course of action for this is. the tool doesn't handle analyzer references correctly today, but I'm not 100% sure what...
Working with @MadEste on this
Okay, the root issue is this line: https://github.com/dotnet/try-convert/blob/bba707f432e1960a3874a3b837c5afd72c1ce8a8/src/MSBuild.Abstractions/MSBuildConversionWorkspace.cs#L23 The default ToolSet loaded is from the .NET SDK, and the path is what is being searched when looking for Microsoft.Windows.UI.Xaml.CSharp.targets. The...
Resolved workaround for now: * New CLI switch for UWP projects * Ensure backup is saved before anything else * When switch is active, find `Microsoft.Windows.UI.Xaml.CSharp.Targets` targets path in the...