sentinel
sentinel copied to clipboard
Upgrading to Sentinel 3.0 breaks support for UUID as primary key
Your Environment
- OS and Version: Debian Buster
- PHP Version: 7.4.0
- Sentinel Version: 3.0.4
Background
We are in the processing of upgrading an existing application from Laravel 5.8 to Laravel 6.0, and in the process have upgraded Sentinel from 2.0 to 3.0. Our user model uses a UUID, handled as a string, as its primary key.
Expected behaviour
Sentinel::findById() should accept a string ID.
Actual behaviour
The following error is thrown:
Symfony\Component\Debug\Exception\FatalThrowableError thrown with message "Argument 1 passed to Cartalyst\Sentinel\Users\IlluminateUserRepository::findById() must be of the type int, string given"
Steps to reproduce
As above.
I can see that Sentinel 3.0 introduced type-hinting in a number of places which seems to be the root cause of this issue, and I can see that there's an outstanding PR #529 that is related to this. Is there any plan to support UUIDs in future? Is there a way to work around this issue short of forking the repo and removing the type hints?
Same with me :( come here for future solution
hi, want to follow up, so what solution did you guys did to fix this? @WildanHarits @dantarian i wanted to use uuid as well
for quick fix, this work
change vendor/cartalyst/sentinel/src/users/eloquentUser
public function getUserId(): int { return $this->getKey(); }
to
public function getUserId(): string { return $this->getKey(); }