Carson Ip
Carson Ip
Is there a reason why `regex` is used instead of Python standard library `re`? I am thinking about moving to PyPy and re is faster than regex in PyPy. As...
list.pop(0) is O(N) such that get() is quadratic. Use deque and six.moves.range to keep get() always O(N). Add tests to HostConnectionPool.
Remove `type: ignore` or at least be more specific about what's being ignored
Currently only binary protobuf encoding is supported in otlp/http, and there is no JSON protobuf encoding support. Ideally apm-server should support both encodings and detect via `Content-Type: application/x-protobuf` vs `Content-Type:...
**APM Server version** (`apm-server version`): confirmed on main (8.13) **Description of the problem including expected versus actual behavior**: request log `http.response.status_code` is not returning the correct status code under otlp/http...
In #10968 we set dynamic: runtime on internal metrics, all aggregated metrics, and TBS metrics. Out of all, internal metrics and all aggregated metrics are actually using synthetic source, meaning...
Let's say we return an error on process.Stop in aggregator: ```go --- a/x-pack/apm-server/aggregation/baseaggregator/aggregator.go +++ b/x-pack/apm-server/aggregation/baseaggregator/aggregator.go @@ -151,5 +151,6 @@ func (a *Aggregator) Stop(ctx context.Context) error { case
The documentation around required APM server API keys privileges is outdated. https://www.elastic.co/guide/en/apm/guide/current/feature-roles.html > The privileges that the fleet-server has are listed directly in ES https://github.com/elastic/elasticsearch/blob/main/x-pack/docs/en/rest-api/security/get-service-accounts.asciidoc?plain=1#L64C28-L85. These privileges need to contain...
1. There is no smoketest coverage on ESS APM snapshot currently. Add it back. 2. We have coverage on latest ESS release through basic-upgrade only. We do not test new...